-
Notifications
You must be signed in to change notification settings - Fork 4k
first init- without record test since we are aiting for SDK 186 #27886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
first init- without record test since we are aiting for SDK 186 #27886
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the functionality of the Application Gateway Firewall custom rule command to support additional variable names.
- Updated help documentation and the ValidateSet attribute to include "ClientAddrXFFHeader" and "GeoLocationXFFHeader".
- Revised ChangeLog.md to document the new properties and a corresponding bug fix.
- Added new scenario tests (PowerShell and C#) to cover the additional custom rule variable functionality.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md | Updated help text with new accepted values. |
src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs | Extended ValidateSet to include new variable names. |
src/Network/Network/ChangeLog.md | Added changelog entries documenting the new variables and bug fix. |
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1 | Added PowerShell scenario tests for custom rule variable functionality. |
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.cs | Updated test runner to include new test scripts. |
@@ -19,7 +19,8 @@ | |||
---> | |||
|
|||
## Upcoming Release | |||
|
|||
* Added property 'GeoLocationXFFHeader' and 'ClientAddrXFFHeader' as VariableName in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`. | |||
* Fixed bug in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable` to add "GeoLocation" as a valid input for VariableName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry mentions adding 'GeoLocation' as a valid input, but the code and help updates reference 'GeoLocationXFFHeader'. Please update the changelog for consistency with the new accepted values.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the change log to make it consistent with the change.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -19,7 +19,8 @@ | |||
---> | |||
|
|||
## Upcoming Release | |||
|
|||
* Added property 'GeoLocationXFFHeader' and 'ClientAddrXFFHeader' as VariableName in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`. | |||
* Fixed bug in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable` to add "GeoLocation" as a valid input for VariableName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the change log to make it consistent with the change.
@yaarark please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@yaarark If you add new test cases, please record it from your local and then include the json files in the PR as well. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.